Skip to content

Comments

Inference workflow small_test failure#5286

Open
GarethCabournDavies wants to merge 2 commits intogwastro:masterfrom
GarethCabournDavies:inference_test_failure
Open

Inference workflow small_test failure#5286
GarethCabournDavies wants to merge 2 commits intogwastro:masterfrom
GarethCabournDavies:inference_test_failure

Conversation

@GarethCabournDavies
Copy link
Contributor

I think it's to do with setting the pegasus site. Lets copy this from the search example and see if that works

  • The author of this pull request confirms they will adhere to the code of conduct

Copilot AI review requested due to automatic review settings February 16, 2026 13:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the small inference workflow example config to align its Pegasus site/profile settings with the existing search workflow example, aiming to resolve the CI “small_test” failure.

Changes:

  • Fixes the [event-170817] label line formatting so it is parsed as an option (not a continuation line).
  • Sets pycbc|primary_site to condorpool_symlink and adds pycbc|submit-directory = ./.
  • Adds condorpool_shared scratch settings and pins the results_page executable to run at condorpool_shared.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GarethCabournDavies GarethCabournDavies added the bug BUG - FIX ASAP label Feb 16, 2026
@GarethCabournDavies
Copy link
Contributor Author

Fixes failure exposed by #5270

[pegasus_profile]
condor|request_memory = 1G
pycbc|primary_site = condorpool_shared
pycbc|primary_site = condorpool_symlink
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One shouldn't change the primary site here. This workflow in general should use the shared site by default.

Copy link
Member

@ahnitz ahnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the inference workflow goes, I think this is OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug BUG - FIX ASAP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants