Skip to content

Update segments module to handle incoming changes from gwpy DataQualityDict updates#417

Draft
eagoetz wants to merge 1 commit intogwpy:masterfrom
eagoetz:rename-url-host
Draft

Update segments module to handle incoming changes from gwpy DataQualityDict updates#417
eagoetz wants to merge 1 commit intogwpy:masterfrom
eagoetz:rename-url-host

Conversation

@eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Dec 5, 2024

This PR updates the segments module to handle changes to the gwpy.DataQualityDict API changing url keyword to host.

Also some minor clean up of the code and setting new version pins.

This PR is draft pending tests

@eagoetz eagoetz self-assigned this Dec 5, 2024
@eagoetz eagoetz added this to the 2.3.0 milestone Dec 5, 2024
@eagoetz eagoetz force-pushed the rename-url-host branch 3 times, most recently from 6380af5 to 332d620 Compare December 13, 2024 18:49
@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.26%. Comparing base (720bd0c) to head (332d620).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
gwsumm/segments.py 54.55% 5 Missing ⚠️
gwsumm/state/core.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   49.64%   49.26%   -0.38%     
==========================================
  Files          60       60              
  Lines        8823     8788      -35     
==========================================
- Hits         4380     4329      -51     
- Misses       4443     4459      +16     
Flag Coverage Δ
Linux 49.26% <53.85%> (-0.38%) ⬇️
macOS 49.26% <53.85%> (?)
python3.10 49.26% <53.85%> (-0.38%) ⬇️
python3.11 49.26% <53.85%> (-0.38%) ⬇️
python3.9 49.27% <53.85%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eagoetz eagoetz modified the milestones: 2.3.0, 2.3.1 Apr 28, 2025
@eagoetz eagoetz modified the milestones: 2.3.1, 2.4.0 May 7, 2025
@eagoetz eagoetz modified the milestones: 2.4.0, 2.4.1 Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant