Skip to content

Switch from python-ligo-lw to igwn-ligolw#434

Merged
eagoetz merged 1 commit intogwpy:masterfrom
eagoetz:igwn-ligolw
Nov 26, 2025
Merged

Switch from python-ligo-lw to igwn-ligolw#434
eagoetz merged 1 commit intogwpy:masterfrom
eagoetz:igwn-ligolw

Conversation

@eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Oct 24, 2025

Like gwdetchar, this PR changes the dependency from python-ligo-lw to igwn-ligolw.

An example showing this works using igwn-ligolw: https://ldas-jobs.ligo-wa.caltech.edu/~evan.goetz/triggers.png

@eagoetz eagoetz self-assigned this Oct 24, 2025
@eagoetz eagoetz added this to the 2.4.0 milestone Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.22%. Comparing base (2c205e5) to head (feb8805).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   49.22%   49.22%           
=======================================
  Files          60       60           
  Lines        8801     8801           
=======================================
  Hits         4332     4332           
  Misses       4469     4469           
Flag Coverage Δ
Linux-python3.10 49.22% <100.00%> (ø)
Linux-python3.11 49.22% <100.00%> (ø)
macOS-python3.10 49.22% <100.00%> (ø)
macOS-python3.11 49.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eagoetz eagoetz changed the title Switch from python-ligo-lw to igwn_ligolw Switch from python-ligo-lw to igwn-ligolw Nov 13, 2025
Copy link
Collaborator

@robertbruntz robertbruntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three suggestions:

  • Does ./docs/environment.yml need to be updated?
  • Maybe update docstring, lines 68-71, in ./gwsumm/tabs/etg.py
  • Maybe update docstring, lines 117-120, in ./gwsumm/triggers.py

@eagoetz
Copy link
Collaborator Author

eagoetz commented Nov 25, 2025

Three suggestions:

* Does ./docs/environment.yml need to be updated?

* Maybe update docstring, lines 68-71, in ./gwsumm/tabs/etg.py

* Maybe update docstring, lines 117-120, in ./gwsumm/triggers.py

These are addressed @robertbruntz. Please have a second look. Thanks for catching this!

Copy link
Collaborator

@robertbruntz robertbruntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eagoetz eagoetz merged commit d3aafb4 into gwpy:master Nov 26, 2025
8 checks passed
@eagoetz eagoetz deleted the igwn-ligolw branch November 26, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants