Merged
Conversation
The get_default_gwf_api function is due to be removed in gwpy 4.0.0 (replaced by gwpy.io.gwf.get_backend, but the result of the call is never used, so we may as well remove it
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 49.25% 49.24% -0.01%
==========================================
Files 60 60
Lines 8804 8799 -5
==========================================
- Hits 4336 4333 -3
+ Misses 4468 4466 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_default_gwf_api()function is due to be removed in gwpy 4.0.0 (replaced bygwpy.io.gwf.get_backend(), but the result of the call is never used, so we may as well remove it.