Open
Conversation
Python 3.13 classmethods behave differently, so the order of decorators needs to change
In the latest LALSuite, the lal.utils.CacheEntry object implements the __fspath__ method, so that os.path.basename and friends can operate directly on it
The items() and values() views acquire the h5py lock ('phil') while iterating, which means that any threading underneath that that attempts to read data ends up in a deadlock (see, e.g. https://gitlab.com/gwpy/gwpy/-/issues/1843)
By iterating over the keys instead, we avoid an unnecessary outer lock and work around the potential hang
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 49.25% 49.27% +0.02%
==========================================
Files 60 60
Lines 8804 8811 +7
==========================================
+ Hits 4336 4341 +5
- Misses 4468 4470 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@duncanmmacleod Thanks for the PR. These basically seem fine to me. One quick question: are these really fixes for GWpy 4? It looks like they are more generic updates. If they are more generic, I suggest the PR title should be modified accordingly. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few random fixes I came across when testing this project against gwpy 4.0.0rc1.