Skip to content

Set OMICRON_HTML in omicron.utils.get_omicron_version #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
areeda merged 1 commit into from
Oct 28, 2023
Merged

Set OMICRON_HTML in omicron.utils.get_omicron_version #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions omicron/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import sys
from pathlib import Path
from shutil import which
from tempfile import gettempdir

from packaging.version import Version

Expand Down Expand Up @@ -98,10 +99,10 @@ def get_omicron_version(executable=None):
executable = executable or find_omicron()
try:
return Version(
subprocess.check_output([
executable,
"version",
]).decode("utf-8").rsplit(maxsplit=1)[-1],
subprocess.check_output(
[executable, "version"],
env={"OMICRON_HTML": gettempdir()},
).decode("utf-8").rsplit(maxsplit=1)[-1],
)
except subprocess.CalledProcessError as ex:
raise RuntimeError(f"failed to determine omicron version from executable: {str(ex)}")
Expand Down