Skip to content

Commit

Permalink
Added to README and some bug fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
h-0-0 committed Sep 27, 2023
1 parent af8c8de commit 6ead6ec
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ So early I haven't even written the docs yet! Will be adding a quick example her
## Coming soon
Currently very much in early stages, first things still to do:
- Auto save when finished a tuning run.
- Auto sbatch job naming and job output naming.
- Add ability to read results, currently can only submit jobs and log metrics during tuning.
- Refine class structure, ie. subclassing, making sure classes have essential methods, what are the essential methods and attributes? etc.
- Refine package structure and sort out github actions like test coverage, running tests etc.
Expand Down
5 changes: 3 additions & 2 deletions slune/savers.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ def get_match(self, params):
missing_params = [[p for p in params if sp in p][0] for sp in stripped_params if sp not in match]
# Now we add back in the values we stripped out
match = match.split('/')
match = [match[0]] + [[p for p in params if m in p][0] for m in match[1:]]
match = '/'.join(match)
if(len(match) > 1):
match = [match[0]] + [[p for p in params if m in p][0] for m in match[1:]]
match = '/'.join(match)
# If there are missing arguments, add them to the path
if len(missing_params) > 0:
match = os.path.join(match, *missing_params)
Expand Down
4 changes: 2 additions & 2 deletions slune/slune.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ def submit_job(sh_path, args):
"""
try:
# Run the Bash script using subprocess
command = ['bash', sh_path] + args
subprocess.run(['sbatch', command], check=True)
command = [sh_path] + args
subprocess.run(['sbatch'] + command, check=True)
except subprocess.CalledProcessError as e:
print(f"Error running sbatch: {e}")

Expand Down

0 comments on commit 6ead6ec

Please sign in to comment.