Conversation
* Added the ability to exclude characters from being minimized * Added the exempt minimized flag to the char specific overrides but also kept the input box, people can use either one or both at the same time
…rride and remove global list
…preventing preview from rendering. Or forcing preview to render when global preview rendering is set off.
Decoupled hotkey authorization from thumbnail generation to ensure hotkeys function correctly even when previews are disabled (globally or via per-character override). - Refactored [scan_eve_windows](cci:1://file:///home/chris/scripts/EVE-Preview-Manager/src/daemon/window_detection.rs:494:0-632:1) to populate [CycleState](cci:2://file:///home/chris/scripts/EVE-Preview-Manager/src/daemon/cycle_state.rs:17:0-34:1) with all identified EVE windows, regardless of thumbnail creation status. - Updated the hotkey whitelist (`allowed_windows`) to include all windows known to [CycleState](cci:2://file:///home/chris/scripts/EVE-Preview-Manager/src/daemon/cycle_state.rs:17:0-34:1). - Updated `hotkey_require_eve_focus` logic to recognize focus on any tracked EVE window, not just those with active thumbnails. This resolves an issue where input events were ignored for clients without rendered previews.
Remove signal-hook and nix from Cargo.toml; both were unused after signal handling was migrated to tokio::signal::unix. Remove two commented-out log statements in debug.rs and cycle_state.rs.
- Remove dbus from runtimeLibs; ksni uses zbus - migrate deprecated xorg.* package references - Install SVG under its reverse-DNS name
Three regressions introduced after v1.6.2 broke custom source handling. 1. scan_eve_windows (regressed in 62305ab): query_tree(root) was used instead of _NET_CLIENT_LIST. Under reparenting WMs (KWin), root's direct children are WM frame windows whose WM_CLASS/WM_NAME don't match app rules, so custom sources already running at daemon startup were never registered in cycle_state. Restored get_client_list() while preserving the non-rendered client tracking added in 62305ab. 2. FocusIn filter stuck state (regressed in 26c74a6): the filter blocked all FocusIn events when event.event != current_window. When a custom source redirects focus to an internal subwindow (e.g. Discord focusing its text input), the expected FocusIn never arrives, leaving current_window permanently set and silently filtering every subsequent EVE FocusIn. Fixed by exempting tracked windows (eve_clients) from the filter — WM-internal intermediate windows remain filtered. 3. is_exempt wrong map (regressed in 26c74a6): the minimize-on-switch filter always looked up character_thumbnails; custom sources live in custom_source_thumbnails and were therefore always minimized regardless of user settings. Simplified to an or_else chain across both maps, which are disjoint by design.
Mirrors the per-character exempt_from_minimize flag. The setting lives on CustomWindowRule and is resolved into DisplayConfig.character_settings by build_display_config(); both minimize paths (hotkey and click) now read from there rather than the raw daemon maps, which never held the rule-derived value.
Mirrors the per-character override_render_preview option. The setting lives on CustomWindowRule and is resolved into DisplayConfig.character_settings by build_display_config(). Also fixes the Always Show gate in process_detected_window, which was reading from the raw daemon maps rather than the resolved character_settings, causing force_enable to always be false for custom sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
Fixed
Other