Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to the annotations #53

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Add description to the annotations #53

merged 3 commits into from
Jul 19, 2024

Conversation

anitacaron
Copy link
Collaborator

@anitacaron anitacaron commented Jul 8, 2024

Fixes #52

It's missing the description for the annotations:

  • language:ISO639-3:description
  • language:ISO639-3:id
  • language:crossref
  • sub:groups
  • population:genetic:study
  • population:microbiome:study
  • population:joshuaproject:description
  • population:googlebook
  • population:distribution
  • population:peoplegroups:description
  • number:populations
  • population:language:spoken
  • population:size
  • population:crossref

@anitacaron anitacaron self-assigned this Jul 8, 2024
@anitacaron anitacaron requested review from abenkahla and Melek-C July 8, 2024 14:31
@Melek-C
Copy link
Collaborator

Melek-C commented Jul 8, 2024

Shall we add the description in the main file?

@anitacaron
Copy link
Collaborator Author

If you prefer, that's fine. But if I have the descriptions, I can also add them to this PR.

@Melek-C
Copy link
Collaborator

Melek-C commented Jul 8, 2024

ok thanks @anitacaron!

@anitacaron
Copy link
Collaborator Author

@Melek-C, are you happy with this PR? If so, could you please add your review? I created issue #54 to remind us later about the remaining annotations without definition.

@Melek-C
Copy link
Collaborator

Melek-C commented Jul 18, 2024

Hi @anitacaron here the some missing definitions:

• language:ISO639-3:description : The ISO 639 Identifier Documentation
• language:ISO639-3:id: Is an international standard for language codes in the ISO 639 series.
• population:genetic:study : Genetic study bibliographic reference.
• population:microbiome:study : Microbiome study bibliographic reference.
• population:joshuaproject:description : “Joshua project’s” population description.
• population:googlebook : “googlebook” population description.
• population:peoplegroups:description “peoplegroups” population description.
• number:populations : Number of populations in the group.
• population:language:spoken : The language spoken by the population.
• population:size : The total number of individuals within a population

These annotation exist in only one or two populations (we should discuss if we keep it or not):
• population:distribution Distribution map of population
• sub:groups

No mapping for these annotations:
• language:crossref
• population:crossref

@anitacaron
Copy link
Collaborator Author

Thank you, @Melek-C!

For language:crossref and population:crossref, I added a definition as they're a grouping annotation.

@anitacaron anitacaron merged commit 2dca4bb into main Jul 19, 2024
1 check passed
@anitacaron anitacaron mentioned this pull request Jul 24, 2024
14 tasks
@anitacaron anitacaron deleted the anitacaron/issue52 branch September 2, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add description to the annotations
2 participants