fix: select Darwin x64 inode ABI#66
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
Exact review target: b3e2a43. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 15, 2026
## [2.25.2](v2.25.1...v2.25.2) (2026-07-15) ### Bug Fixes * select Darwin x64 inode ABI ([#66](#66)) ([d9617d2](d9617d2))
|
🎉 This PR is included in version 2.25.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readdir$INODE64on Intel macOS so FFI receives the modern 64-bit dirent layoutRelease incident
v2.25.1published to npm/GitHub, but its macOS Intel asset verification failed withDescriptor-bound directory entry is malformed; downstream release assets/Homebrew were therefore skipped. Apple SDK headers confirm that Intel callers are redirected to the$INODE64symbol while direct FFI lookup of unsuffixedreaddirreaches the legacy layout.Verification
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.