Fix release-prepare CI typecheck regressions

[roodboi]

Summary

• fix the TypeScript regressions that were breaking the Release Prepare workflow
• update the affected Linear/tickets/runtime test fixtures so the stricter types compile cleanly
• opt the release workflow into the Node 24 JavaScript action runtime

Verification

• bun run turbo:typecheck
• bun run privacy:check
• bun run turbo:check
• bun run turbo:test

Summary by CodeRabbit

• New Features

  • Paginated project listing for Linear integrations to improve large-project handling.

• Bug Fixes

  • Safer YAML frontmatter parsing to avoid crashes on malformed input.
  • Guarded merging of remote ticket links to prevent undefined-merge issues.

• Improvements

  • Stronger type and authority handling for ticket and conflict resolution.
  • Clearer runtime result shapes for more reliable error reporting.

• Tests

  • Expanded and hardened tests for Linear sync, pagination, and runtime caching.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3009855

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 755a1e90-4457-4e4a-8679-8636852b9296

📥 Commits

Reviewing files that changed from the base of the PR and between 89baa94 and 3009855.

📒 Files selected for processing (12)

• packages/cli/index.ts
• packages/db/tests/smoke.test.ts
• packages/db/tsconfig.json
• services/auth-broker/tests/config.test.ts
• services/auth-broker/tsconfig.json
• src/control-plane/extensions/linear/client.ts
• src/control-plane/extensions/linear/commands.ts
• src/control-plane/extensions/tickets/domain.ts
• tests/config-paths.test.ts
• tests/linear-client.test.ts
• tests/linear-commands.test.ts
• tsconfig.json

 ___________________________________________________________________
< That's not a helper function. That's a co-dependent relationship. >
 -------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Walkthrough

This PR improves type safety across ticket and linear extension modules through discriminated unions and explicit type narrowing, strengthens null-safety with guards and fallbacks, refactors option parsing logic, adds test infrastructure helpers, and updates GitHub Actions configuration for JavaScript actions.

Changes

Cohort / File(s)	Summary
GitHub Actions Configuration .github/workflows/release-prepare.yml	Added job-level environment variable FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true" to the semantic-release workflow job.
Type System Strengthening src/lib/runtime-projects.ts, src/control-plane/extensions/tickets/domain.ts, src/control-plane/extensions/linear/commands.ts	Converted RuntimeProjectsResult to a discriminated union keyed by ok flag; tightened TicketFieldState.authority type to TicketFieldAuthority union; added explicit DisplayCell type constraints and type narrowing for Linear artifacts.
Null Safety & Defensive Guards src/control-plane/extensions/linear/project-artifacts.ts, src/control-plane/extensions/tickets/provenance.ts	Added null-safe YAML parsing fallback with ?? ""; guarded against undefined remotes in buildTicketRemoteLinks; introduced normalizeConflictAuthority helper to validate conflict authority values.
Control Flow & Parsing Refactoring src/control-plane/extensions/tickets/commands.ts, src/daemon/runtime-cache.ts, src/cli/prerequisites.ts	Refactored parseTicketDocumentOption to handle --kind and --role via separate consumeOptionValue calls; adjusted resolveRefreshResult argument construction; replaced includes() with explicit some() equality check.
Data Normalization src/control-plane/extensions/tickets/normalized-model.ts	Consolidated legacy assignee normalization; added typed casts for array iterations; converted assertion helpers from arrow functions to function declarations with asserts type predicates.
Test Infrastructure & Helpers tests/linear-commands.test.ts, tests/runtime-cache.test.ts, tests/tickets-git-channel.test.ts	Introduced typed test helpers createEmptyTicketDetail and createProjectArtifactLinearClient for standardized mocking; updated test fixtures with additional meta fields; added forceBareClone configuration option.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 Type safety blooms like clover in the spring,
Null guards and unions make the refactored code sing,
With tested helpers hopping through the test files clean,
Each discriminated path creates a safer in-between.
The linear artifacts and tickets now align,
A rabbit's work improving contracts, line by line! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the primary objective of the PR—fixing TypeScript regressions in the release-prepare CI workflow—which aligns with the main changes across multiple type-related updates and workflow configuration.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/release-prepare-typecheck

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

src/control-plane/extensions/linear/commands.ts (1)

4143-4146: Consider converting this touched object-shape alias to an interface.

The new "review_required" member makes sense, but RecordedSyncConflict is still an object-shape type in a touched TS region. Converting it would keep this file aligned with the repo convention.

♻️ Small cleanup

-type RecordedSyncConflict = {
+interface RecordedSyncConflict {
   readonly field: string
   readonly authority: "hack" | "linear" | "review_required"
   readonly summary: string
   readonly localValue?: TicketMetadataValue
   readonly remoteValue?: TicketMetadataValue
 }

As per coding guidelines: `**/*.{ts,tsx}`: Prefer `interface` for defining object shapes in TypeScript

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/control-plane/extensions/linear/commands.ts` around lines 4143 - 4146,
Change the object-shape type alias RecordedSyncConflict into an equivalent
interface to match project conventions: replace the `type RecordedSyncConflict =
{ ... }` declaration with `interface RecordedSyncConflict { ... }`, preserving
the readonly modifiers, the field names (`field`, `authority`, `summary`) and
the union literal type for `authority` ("hack" | "linear" | "review_required")
so all usages of RecordedSyncConflict remain compatible.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/control-plane/extensions/linear/commands.ts`:
- Around line 2581-2583: The remote project lookup uses the one-page
listProjects({ first? }) call which only returns DEFAULT_PROJECT_SYNC_LIMIT
items, causing resolveProjectArtifactTarget() to falsely conclude "No Linear
project matches..." for workspaces > limit; update the code that calls
listProjects (the client wrapper used by resolveProjectArtifactTarget and the
call sites around the listed locations) to page through results until either the
matching project is found or no more pages remain (using cursor/after tokens or
repeated calls with offset logic), aggregating pages before applying the
--project-name / --team-id filter, and ensure DEFAULT_PROJECT_SYNC_LIMIT remains
the per-page size while the loop continues requests until completion or match.

In `@src/control-plane/extensions/tickets/domain.ts`:
- Around line 11-16: There's a duplicate type re-export of TicketDocument,
TicketDocumentKind, and TicketDocumentRole (they're already exported near the
top via `export type { ... } from "./documents.ts"`); remove the redundant
re-export at the later location that references those same identifiers (the
duplicate at the end of the file around the later export block) so the
TS2300/TS2304 errors go away, or if those identifiers are meant to be used as
local names first, change that later export to import them as types before
re-exporting—preferably just delete the duplicate re-export.

---

Nitpick comments:
In `@src/control-plane/extensions/linear/commands.ts`:
- Around line 4143-4146: Change the object-shape type alias RecordedSyncConflict
into an equivalent interface to match project conventions: replace the `type
RecordedSyncConflict = { ... }` declaration with `interface RecordedSyncConflict
{ ... }`, preserving the readonly modifiers, the field names (`field`,
`authority`, `summary`) and the union literal type for `authority` ("hack" |
"linear" | "review_required") so all usages of RecordedSyncConflict remain
compatible.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7482d12-e866-4fdc-a983-9307c9c10ac0

📥 Commits

Reviewing files that changed from the base of the PR and between ef8f863 and 89baa94.

📒 Files selected for processing (13)

• .github/workflows/release-prepare.yml
• src/cli/prerequisites.ts
• src/control-plane/extensions/linear/commands.ts
• src/control-plane/extensions/linear/project-artifacts.ts
• src/control-plane/extensions/tickets/commands.ts
• src/control-plane/extensions/tickets/domain.ts
• src/control-plane/extensions/tickets/normalized-model.ts
• src/control-plane/extensions/tickets/provenance.ts
• src/daemon/runtime-cache.ts
• src/lib/runtime-projects.ts
• tests/linear-commands.test.ts
• tests/runtime-cache.test.ts
• tests/tickets-git-channel.test.ts