fix(tls): check isMac before isLinux in globalTrust - #57
Merged
Conversation
…mac suite The macOS test suite mocks isMac()=true but ran on Linux CI where the real isLinux() won, sending globalTrust down the Linux bundle path against the runner's real /etc/ssl/certs. Mac branch now checks first, and the suite pins isLinux()=false. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
roodboi
pushed a commit
that referenced
this pull request
Jul 8, 2026
## 3.2.0 (2026-07-08) * Merge branch 'main' into fix/container-trust-bundle ([8338b58](8338b58)) * Merge pull request #56 from hack-dance/fix/container-trust-bundle ([9cb82c1](9cb82c1)), closes [#56](#56) * Merge pull request #57 from hack-dance/fix/global-trust-platform-order ([e3c6da0](e3c6da0)), closes [#57](#57) * fix(tls): check isMac before isLinux in globalTrust; pin platform in mac suite ([4d35428](4d35428)) * fix(tls): containers get combined public+local trust, never a stripped bundle ([651f234](651f234)) * fix(tls): generate the combined trust bundle on Linux hosts ([e339920](e339920)) * test(tls): neutral fixture paths for the privacy check ([c4be004](c4be004)) * feat(agents): onboarding lessons from first field hack init --with run ([2190dd8](2190dd8))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-prepare failed on main: tests/global-command.macos.test.ts mocks isMac()=true but not isLinux(), and the new Linux branch in globalTrust ran first on the Linux runner — building a real bundle from /etc/ssl/certs instead of the mocked keychain export. Mac branch now checks first (mutually exclusive on real platforms; mock-safe in tests), and the macOS suite pins isLinux()=false.
🤖 Generated with Claude Code