fix: review leaderboard total didn't account for rejected/returned reviews - #75
Merged
Conversation
total was already COUNT(*) over all project_reviews statuses, but the leaderboard only broke it into approved/changes_needed/banned, so rejected and returned (overturned first-pass) rows were silently folded into total without a visible column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
totalcolumn was alreadyCOUNT(*)over everyproject_reviewsrow, but the table only broke that out into approved / changes_needed / banned, sorejectedandreturned(a first-pass approval overturned at second-pass audit) rows were silently folded into total with no visible columngetReviewLeaderboardinbackend/src/admin/admin.service.tsnow also countsrejectedandreturnedfrontend/src/routes/admin/+page.svelteadds Rejected and Returned columns so total = sum of all shown columnsno "fraud pending" bucket here since that's a project status, not a
project_reviews.statusvalue.Test plan
/adminleaderboard tab, confirm total = approved + changes needed + banned + rejected + returned for each reviewer row