Skip to content

fix: tutorial scrollymation snapping to Go! section on landing #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EDRipper merged 1 commit into from
Jul 31, 2026
Merged

fix: tutorial scrollymation snapping to Go! section on landing #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions frontend/src/routes/tutorial/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,18 @@

// Prevent scrolling past the bottom back into the scrollymation
$effect(() => {
// Depend on scrollY so this reruns on scroll, but read window.scrollY for
// the actual value: the scrollY binding lags the native scroll event, so
// right when `locked` flips true it can still read stale (near-zero) and
// clamp us up to `top` before the real position is ever reflected.
void scrollY;
if (locked && skyEl) {
const top = skyEl.offsetTop + innerHeight;
const bottom = skyEl.offsetTop + skyEl.offsetHeight - innerHeight;
if (scrollY < top) {
const current = window.scrollY;
if (current < top) {
window.scrollTo(0, top);
} else if (scrollY > bottom) {
} else if (current > bottom) {
window.scrollTo(0, bottom);
}
}
Expand Down
Loading