Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torsion app #30

Merged
merged 4 commits into from
Aug 30, 2024
Merged

torsion app #30

merged 4 commits into from
Aug 30, 2024

Conversation

drnez
Copy link
Contributor

@drnez drnez commented Aug 21, 2024

Contains the README.md for my app 'torsion'. Final feedback would be greatly appreciated!

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 4:38pm

@faisalsayed10
Copy link
Member

image

hmm why is there a white overlay over the entire app

@drnez
Copy link
Contributor Author

drnez commented Aug 24, 2024

Should I remove the top bar?

@faisalsayed10
Copy link
Member

no not that, the entire screen looks faded for some reason as if there's an overlay over it?

@drnez
Copy link
Contributor Author

drnez commented Aug 24, 2024

Ah I had added a slight gradient. Is this better?image

Copy link
Member

@faisalsayed10 faisalsayed10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @drnez! I feel like the UI is very basic right now and isn't appealing for the users to use. I would like to see a great UI that looks production-grade before we can proceed with the grant

@drnez
Copy link
Contributor Author

drnez commented Aug 28, 2024

I changed some colours, text sizes and positions, made a new button theme and moved logout to the top right (among more minor tweaks). It seems to have really improved the look - please do let me know if any further changes are needed, UI has never been my strong side :). https://github.com/user-attachments/assets/dec17e89-35a8-42ad-9fc4-f080bcddbfda

@faisalsayed10
Copy link
Member

Hey @drnez! Totally understand that, here are some specific feedbacks I have. If you can just fix these issues, we'll be good to go :))

image

image

image

image

@drnez
Copy link
Contributor Author

drnez commented Aug 29, 2024

Hi, thanks a lot for that - it was really useful, and I definitely wouldn't have been able to think of it all myself!

Is this the type of thing you're looking for on the 'Select Team' screen?
image
image

And is it better with spacers?
image

@drnez
Copy link
Contributor Author

drnez commented Aug 29, 2024

I made the requested changes:
https://github.com/user-attachments/assets/b6b1071c-c773-4fa2-ad22-b8d7016d634c

As always feedback would be really appreciated, thanks again for the guidance above - it really was very useful!

Copy link
Member

@faisalsayed10 faisalsayed10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, this is what I was looking for :)

@faisalsayed10 faisalsayed10 merged commit ac0ce5f into hackclub:main Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants