add public channel managers endpoint - #5
Open
deployor wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for querying Slack “channel manager” role assignments via the existing proxy + pipeline service, enabling downstream bots/services to rely on channel managers (including for private channels) rather than channel creators.
Changes:
- Extend the proxy allowlist to permit
admin.roles.listAssignmentscalls. - Add the required Slack app OAuth scope (
admin.roles:read) to the manifest. - Introduce a new
GET /channel-managersendpoint in the pipeline service that pages through role assignments and returns manager user IDs for a channel.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
proxy/app.py |
Allows the proxy to forward admin.roles.listAssignments using the admin credential. |
pipeline/slack.manifest.yaml |
Adds admin.roles:read so the Slack app can call role assignment APIs. |
pipeline/service/app.py |
Adds a public /channel-managers HTTP endpoint backed by proxy calls to Slack admin role assignment APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows any bot or person to look up channel managers without having to use a self-bot, even in private channels.
This means that bots such as at-channel, bChannel, etc. can rely on channel managers rather than the creators of the channel for private channels. This makes permission checks much easier!