Skip to content

Conversation

@alessandroberna
Copy link
Contributor

Unfortunately the issue is still not fixed in the latest release.
With ImageMagick 7 the warning gets printed both when using convert and magick convert:
image

Since the correct way to issue the convert command seems to be using magick without the tool name, simply appending magick in front of the old command does not resolve the issue:
image

I tried to keep the changes minimal:

  • Introduced a convert variable that is set to $magick if it exists, or to convert otherwise.
  • Updated lines that used $magick convert to use $convert.

There's no brittle version parsing and the fix does not depend on other standalone tools that may be deprecated in the future.
I also made sure that the non-sixel error message prints the correct ImageMagick command.

I had to create a new PR as I did not have the permissions to re-open #73.
I hope this PR addresses the issues more effectively.

Copy link
Owner

@hackerb9 hackerb9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hackerb9 hackerb9 merged commit 2b7c9e7 into hackerb9:master Jun 12, 2024
@hackerb9
Copy link
Owner

Thank you for filing a new pull request. I'll have to talk with the ImageMagick folks and see what their intention is for other breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants