Fix the project tag values on the ECR repositories #195

Overview

We need the ECR repositories tagged with their project name rather than their repository name, because five of the eight currently carry a value like vrms-backend where the project is vrms — which would deny that project's own CI role once permissions are scoped by tag.

Action Items

• In each project's ecr.tf, stop overloading project_name to carry the repository name. Pass the project name, and use the module's existing repository_name variable for the repository. For terraform/projects/vrms/ecr.tf this means:

  project_name    = local.project_name    # "vrms"
  repository_name = "vrms-backend"

• Apply the same correction to every project directory that overloads it. Confirmed affected on 2026-09-01: vrms (two repositories), people-depot, home-unite-us and civic-tech-jobs. civictechindex is already correct and should be left alone.
• Confirm the plan changes only the tag value. A plan that proposes replacing or renaming an ECR repository is wrong and must not be applied — repository names are referenced by every project's CI pipeline, and a rename breaks their deployments.
• Decide what to do about homeuniteus, which has no project tag at all. Establish whether it is still in use before tagging it or proposing its removal.
• After the PR merges, confirm the live tag on every repository: aws ecr list-tags-for-resource --resource-arn <arn>. All eight should carry a project name, and none should carry a repository name.

Resources/Instructions

• The module variable already exists for exactly this case: terraform/modules/ecr/main.tf, variable "repository_name", described as "Repository name, for repositories whose name predates the project naming convention. Defaults to project_name."
• This corrects the result of add project tag to ecr #131, not that issue's work. add project tag to ecr #131 added the tag correctly; the wrong values come from the calling code.
• Live values on 2026-09-01: vrms-backend and vrms-frontend are tagged with their own names rather than vrms; people-depot-backend, home-unite-us-fullstack and civic-tech-jobs-fullstack likewise; civictechindex-backend-prod and -stage are correctly tagged civictechindex; homeuniteus is untagged.