Repository navigation
Switch vrms-frontend-dev to its own execution role - #239
Merged
Merged
Conversation
Contributor
|
Terraform plan in terraform Plan: 1 to add, 1 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.vrms.module.frontend_dev_service.aws_ecs_service.fargate[0] will be updated in-place
!~ resource "aws_ecs_service" "fargate" {
id = "arn:aws:ecs:us-west-2:035866691871:service/incubator-prod/vrms-frontend-dev"
name = "vrms-frontend-dev"
tags = {
"project" = "vrms"
}
!~ task_definition = "arn:aws:ecs:us-west-2:035866691871:task-definition/vrms-frontend-dev:8" -> (known after apply)
# (18 unchanged attributes hidden)
# (7 unchanged blocks hidden)
}
# module.vrms.module.frontend_dev_service.aws_ecs_task_definition.task must be replaced
-/+ resource "aws_ecs_task_definition" "task" {
!~ arn = "arn:aws:ecs:us-west-2:035866691871:task-definition/vrms-frontend-dev:8" -> (known after apply)
!~ arn_without_revision = "arn:aws:ecs:us-west-2:035866691871:task-definition/vrms-frontend-dev" -> (known after apply)
!~ container_definitions = jsonencode(
!~ [
!~ {
- mountPoints = []
name = "vrms-frontend-dev"
!~ portMappings = [
!~ {
- protocol = "tcp"
# (2 unchanged attributes hidden)
},
]
- systemControls = []
- volumesFrom = []
# (8 unchanged attributes hidden)
},
]
)
!~ enable_fault_injection = false -> (known after apply)
!~ execution_role_arn = "arn:aws:iam::035866691871:role/incubator-prod-ecs-task-role" -> "arn:aws:iam::035866691871:role/ecs-execution-vrms-frontend-dev" # forces replacement
!~ id = "*****************" -> (known after apply)
!~ revision = 8 -> (known after apply)
tags = {
"project" = "vrms"
}
# (12 unchanged attributes hidden)
}
Plan: 1 to add, 1 to change, 1 to destroy.✅ Plan applied in Terraform apply (OIDC) #91 |
ale210
added a commit
that referenced
this pull request
Sep 13, 2026
Part 3 of 3 for #201: `use_own_execution_role` now defaults to `true`, which switches the remaining nine services to their own project-scoped execution roles. The canary line on `vrms-frontend-dev` is removed, since the default now covers it. **Expected plan:** 9 to add, 9 to change, 9 to destroy. That's nine task definitions replaced, each forced only by `execution_role_arn`, and nine services updated in place. `vrms-frontend-dev` doesn't change. The #239 canary proved all three permissions on a live task: image pull, the SSM secret, and writing to a new log stream. The variable stays for now. Once nothing uses the shared `incubator-prod-ecs-task-role`, a follow-up deletes the role and the variable together. Closes #201 Closes #203 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 3 for #201: switches
vrms-frontend-devalone to its own execution role,ecs-execution-vrms-frontend-dev, which #238 created.Expected plan: the
vrms-frontend-devtask definition is replaced and its service updated in place. Nothing else changes.Before this, all 10 new roles were checked with the IAM policy simulator. ECR and SSM are allowed for the role's own project only; logs are allowed for its own log group only. The simulator can't evaluate log ARNs whose group name contains
/, so this canary is what proves the logs permission.After apply:
/ecs/vrms-frontend-dev.ResourceInitializationError.Refs #201