Skip to content

Fix stale ENI comment on the ECS service lifecycle #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ale210 merged 1 commit into from
Oct 10, 2026
Merged

Fix stale ENI comment on the ECS service lifecycle #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions terraform/modules/container/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,10 +617,9 @@ resource "aws_ecs_service" "fargate" {


# Deliberately no create_before_destroy here, unlike the target group and security group
# above. Two services can coexist, but each task consumes an ENI, and the cluster's two
# m5.large instances already hold 12 ENI attachments for 10 running tasks. Standing a full
# duplicate service up alongside the original risks exhausting ENI slots, which ECS cannot
# binpack on. See hackforla/incubator#184.
# above. Two services can coexist, but the cluster is one host with about 1 GB of memory to
# spare. Standing a full duplicate service up alongside the original doubles its memory
# reservation and risks leaving tasks unplaceable. See hackforla/incubator#184.
lifecycle {
ignore_changes = [desired_count]
}
Expand Down
Loading