Skip to content

Resolve CodeQL Alert #49 in wins-share-form.html- Generated by GHA #6668

Closed
#8797
Closed
Resolve CodeQL Alert #49 in wins-share-form.html- Generated by GHA#6668
#8797
Assignees
cchrizzle
Labels
Complexity: MediumFeature: Code AlertsHLC: SHomepage Launch Countdown Should HaveP-Feature: Wins Pagehttps://www.hackforla.org/wins/role: front endTasks for front end developerssize: 1ptCan be done in 4-6 hours
Milestone
02. Security

Description

@HackforLABot
HackforLABot
opened on Apr 17, 2024

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to resolve the new alert (49) and either recommend dismissal of the alert or update the code files to resolve the alert.

Action Items

  • The following action item serves to "link" this issue as the "tracking issue" for the CodeQL alert and to provide more details regarding the alert: https://github.com/hackforla/website/security/code-scanning/49
  • In a comment in this issue, add your analysis and recommendations. The recommendation can be one of the following: dismiss as test, dismiss as false positive, dismiss as won't fix, or update code. An example of a false positive is a report of a JavaScript syntax error that is caused by markdown or liquid symbols such as --- or {%
  • If the recommendation is to dismiss the alert:
    • Apply the label ready for dev lead
    • Change issue status to "Questions / In Review"
  • If the recommendation is to update code:
    • Create an issue branch and proceed with the code update
    • Test using Docker to ensure that there are no changes to any affected webpage(s)
    • Proceed with pull request in the usual manner

Resources/Instructions

This issue was automatically generated from the CodeQL Create Issues workflow

Activity

  1. HackforLABot
    added
    ready for dev leadIssues that tech leads or merge team members need to follow up on
    on Apr 17, 2024
  2. github-actions
    added
    Feature MissingThis label means that the issue needs to be linked to a precise feature label.
    size: missing
    role missing
    Complexity: Missing
    on Apr 17, 2024
  3. ExperimentsInHonesty
    added this to the 02. Security milestone on Apr 22, 2024
  4. roslynwythe
    added
    Complexity: Medium
    size: 1ptCan be done in 4-6 hours
    role: front endTasks for front end developers
    P-Feature: Wins Pagehttps://www.hackforla.org/wins/
    Feature: Code Alerts
    and removed
    ready for dev leadIssues that tech leads or merge team members need to follow up on
    Feature MissingThis label means that the issue needs to be linked to a precise feature label.
    size: missing
    role missing
    on Apr 28, 2024

  5. 21 remaining items

  6. HackforLABot commented on Jun 19, 2026

    @HackforLABot
    HackforLABot
    on Jun 19, 2026 · Hidden as outdated
    Author
  7. HackforLABot
    moved this from Prioritized backlog to New Issue Approval in P: HfLA Website: Project Boardon Jun 19, 2026
  8. daras-cu
    moved this from New Issue Approval to Ready for Prioritization in P: HfLA Website: Project Boardon Jun 29, 2026
  9. daras-cu
    added
    Ready for Prioritization
    on Jun 29, 2026
  10. kimberlyvaldez07
    added
    HLC: SHomepage Launch Countdown Should Have
    and removed
    Homepage Launch CountdownTracking all issues related to homepage launch
    on Aug 4, 2026
  11. daras-cu
    moved this from Ready for Prioritization to Prioritized backlog in P: HfLA Website: Project Boardon Sep 15, 2026
  12. daras-cu
    removed
    Ready for Prioritization
    Status: Unassigned by BotPreviously-prioritized issues that bot places in "New Issue Approval"
    on Sep 15, 2026
  13. cchrizzle
    self-assigned this
    on Sep 17, 2026

  14. HackforLABot commented on Sep 17, 2026

    @HackforLABot
    HackforLABot
    on Sep 17, 2026
    ContributorAuthor

    Hi @cchrizzle, thank you for taking up this issue! Hfla appreciates you :)

    Do let fellow developers know about your:-
    i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
    ii. ETA: (When do you expect this issue to be completed?)

    You're awesome!

    P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

  15. cchrizzle
    moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Boardon Sep 17, 2026

  16. cchrizzle commented on Sep 17, 2026

    @cchrizzle
    cchrizzle
    on Sep 17, 2026
    Member

    i. Availability: M-F 9am - 12pm
    ii. ETA: Tuesday 9/22 by 12pm

  17. cchrizzle commented on Sep 22, 2026

    @cchrizzle
    cchrizzle
    on Sep 22, 2026
    Member

    Analysis: form is a local variable to pull the name and email from the field with id nameEmailForm and does not get reassigned within the function.

    Recommendation: update code using const to declare form like the 2nd form function does in line 368.

  18. daras-cu
    closed this as completedin #8797on Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Complexity: MediumFeature: Code AlertsHLC: SHomepage Launch Countdown Should HaveP-Feature: Wins Pagehttps://www.hackforla.org/wins/role: front endTasks for front end developerssize: 1ptCan be done in 4-6 hours

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions