Skip to content

ER: Remove unused search id query selectors #8803

Description

@castillios

Emergent Requirement - Problem

In assets/js/current-projects.js, there are two query selectors that select an id named search. However, in _includes/current-projects.html, there is no existing id for search.

We must remove any query selectors for search in assets/js/current-projects.js since it is an unused id.

Issue you discovered this emergent requirement in

Date discovered

9/19/2026

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@ldaws003 @castillios

What happens if this is not addressed

Any deprecated IDs may continue to bloat the codebase if left unaddressed.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

  • Create a small issue that lists the 2 instances of document.querySelector('#search') to be removed from assets/js/current-projects.js.

  • In your issue body under the Instructions section, include before and after code snippets as follows:

    Before:

    const allInputEl = Array.from(document.querySelectorAll('#search-desktop, #search-mobile, #search'));
    

    After removing #search:

    const allInputEl = Array.from(document.querySelectorAll('#search-desktop, #search-mobile'));
    

    Before:

    function searchCloseEventHandler(e){
        e.preventDefault();
        const input = document.querySelector('#search-desktop') || document.querySelector('#search-mobile') || document.querySelector('#search');
        if (input) input.value="";
    }
    

    After removing document.querySelector('#search'):

    function searchCloseEventHandler(e){
        e.preventDefault();
        const input = document.querySelector('#search-desktop') || document.querySelector('#search-mobile');
        if (input) input.value="";
    }
    
  • After listing implementation details, include an action item to test and verify that the changes still work by performing a search in both mobile and desktop views on the Projects and Projects-Check pages

  • Ensure your issue labels match this parent ER (with the exception of Issue Making: Level 1, ER and non-PR contribution)

  • Once the overall issue has been drafted, in the sidebar under Relationships, add this ER as a parent to your issue

  • Review and if ready, apply the ready for merge team label

Activity

  1. added
    Complexity: SmallTake this type of issues after the successful merge of your second good first issue
    size: 0.25ptCan be done in 0.5 to 1.5 hours
    EREmergent Request
    on Sep 26, 2026
  2. added
    ready for dev leadIssues that tech leads or merge team members need to follow up on
    on Sep 26, 2026
  3. daras-cu commented on Sep 26, 2026

    @daras-cu
  4. added
    ready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritization
    and removed
    ready for dev leadIssues that tech leads or merge team members need to follow up on
    on Sep 26, 2026
  5. added
    DraftIssue is still in the process of being created
    and removed on Sep 27, 2026
  6. 1 remaining item

  7. castillios commented on Sep 27, 2026

    @castillios
    Author
  8. daras-cu commented on Sep 27, 2026

    @daras-cu
  9. castillios commented on Oct 1, 2026

    @castillios
    Author
  10. added
    non-PR contributionFor wiki additions/revisions, audit spreadsheet contributions, issue-making ERs and Epics, etc.
    and removed
    DraftIssue is still in the process of being created
    ready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritization
    on Oct 1, 2026
  11. added this to the x. Technical debt milestone on Oct 1, 2026
  12. self-assigned this
    on Oct 1, 2026
  13. HackforLABot commented on Oct 1, 2026

    @HackforLABot
    Contributor

    Hi @yepezjuan, thank you for taking up this issue! Hfla appreciates you :)

    Do let fellow developers know about your:-
    i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
    ii. ETA: (When do you expect this issue to be completed?)

    You're awesome!

    P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

  14. yepezjuan commented on Oct 1, 2026

    @yepezjuan
    Member

    Availability: M, Th, F (5-7pm)
    ETA: Thurs, Oct 8, 2026

  15. castillios commented on Oct 7, 2026

    @castillios
    MemberAuthor

    Hi @yepezjuan! Thanks for creating the issue for this ER. I have a bit of feedback before I mark it as Ready for Prioritization.

    • Be sure to add capitalization to each of the action items for consistency
    • There's a minor spelling error, not a big deal!: 'asstes/js/current-projects.js' should be 'assets/js/current-projects.js'
    • Our Blank Issue Template unfortunately doesn't contain the Prerequisite section. Would you be able to add the following before the Overview section?:
      ###Prerequisite
      1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our [Getting Started page](https://www.hackforla.org/getting-started) and attend an onboarding session.
      2. Before you claim or start working on an issue, please make sure you have read our [How to Contribute to Hack for LA Guide](https://github.com/hackforla/website/blob/7f0c132c96f71230b8935759e1f8711ccb340c0f/CONTRIBUTING.md).
      
    • This one's on me for not initially including it in the ER, but could you add these links to the Resources section? These are the pages that will need to be tested on the devs localhost:

    Thanks for your patience and work on this issue! Feel free to ping me on Slack once the edits have been made and I'll re-review ASAP.

  16. castillios commented on Oct 8, 2026

    @castillios
    MemberAuthor

    Hi @yepezjuan, thanks for making those changes! I've marked your issue as Ready for Prioritization and will close this ER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Complexity: SmallTake this type of issues after the successful merge of your second good first issueEREmergent RequestIssue Making: Level 1Make issues from a template and a spreadsheetP-Feature: Projects pagehttps://www.hackforla.org/projects/non-PR contributionFor wiki additions/revisions, audit spreadsheet contributions, issue-making ERs and Epics, etc.role: back end/devOpsTasks for back-end developerssize: 0.25ptCan be done in 0.5 to 1.5 hours

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions