Skip to content

Fix link in TDM calculator site link - #8820

Merged
sushma110396 merged 1 commit into
hackforla:gh-pagesfrom
palak-hellowrld:fix-link-tdm-8753
Oct 7, 2026
Merged

sushma110396 merged 1 commit into
hackforla:gh-pagesfrom
palak-hellowrld:fix-link-tdm-8753

Conversation

@palak-hellowrld

Copy link
Copy Markdown
Member

Fixes #8753

What changes did you make?

  • Updated the Test Site url in for TDM calculator.

Why did you make the changes (we will use this info to test)?

  • The previous test site link didn't work

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b palak-hellowrld-fix-link-tdm-8753 gh-pages
git pull https://github.com/palak-hellowrld/website.git fix-link-tdm-8753

@github-actions github-actions Bot added role: front end Tasks for front end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours status: 2 Weeks Inactive An issue that has not been updated by an assignee for two weeks HLC: M Homepage Launch Countdown Must Have labels Oct 4, 2026
@mocodesss
mocodesss self-requested a review October 4, 2026 21:41
@mocodesss

Copy link
Copy Markdown
Member

ETA: 10/6 EOD
Availability: Weekends, Mon/Wed/Thur after 7:30pm, Tues after 2pm (PT)

@castillios castillios removed the status: 2 Weeks Inactive An issue that has not been updated by an assignee for two weeks label Oct 6, 2026

@mocodesss mocodesss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @palak-hellowrld! This looks great. Thanks for adding those screenshots of the old and new link target. I tested on my device as well and it's all working. Nice Job!

@cchrizzle

Copy link
Copy Markdown
Member

ETA: Today by 1pm
Availability: Today until 1pm, tomorrow 12-1pm, Friday 9-12pm

@cchrizzle cchrizzle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @palak-hellowrld, looks good to me!

  • You fixed the original issue.
  • Good branch naming convention.
  • Checked for alerts and the included screenshots clearly show the changes before and after.

Great job, approved!

@sushma110396
sushma110396 merged commit 7b8d440 into hackforla:gh-pages Oct 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue HLC: M Homepage Launch Countdown Must Have P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Fix link to Test Site on TDM Calculator's Project Page

5 participants