Skip to content

Fix capitalization of GitHub in 2FA main guide subheader - #8666

Merged
xnealcarson merged 1 commit into
hackforla:gh-pagesfrom
anthonylo87:fix-github-casing-7418
May 31, 2026
Merged

xnealcarson merged 1 commit into
hackforla:gh-pagesfrom
anthonylo87:fix-github-casing-7418

Conversation

@anthonylo87

@anthonylo87 anthonylo87 commented May 28, 2026 •

Copy link
Copy Markdown
Member

Fixes #7418

What changes did you make?

  • Update casing from "Github" to GitHub" on 2FA Guide page main content sub header

Why did you make the changes (we will use this info to test)?

  • Changes are needed to display company name correctly and consistently throughout the website

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied 2FA_Before
Visuals after changes are applied 2FA_After

@github-actions

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b anthonylo87-fix-github-casing-7418 gh-pages
git pull https://github.com/anthonylo87/website.git fix-github-casing-7418

@github-actions github-actions Bot added good first issue Good for newcomers role: front end Tasks for front end developers P-Feature: Toolkit https://www.hackforla.org/toolkit/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 28, 2026
@egcuriel
egcuriel self-requested a review May 28, 2026 23:11
@egcuriel

Copy link
Copy Markdown
Member

Review ETA: 05/29/26 EOD
Availability: M-Sun (5 pm - 11 pm)

@egcuriel egcuriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anthonylo87!

I have reviewed this pull request and verified the following:

PR Verification:

  • Pull Request uses the correct branch
  • Original issue is linked
  • Screenshots included
    • Before
    • After

Technical Verification:

  • Issue requirements are addressed correctly
  • Changes are accurately represented locally across viewports:
    • Desktop
    • Mobile
  • No new console errors or warnings present
  • No unresolved CodeQL alerts

Notes:

  • I appreciate how descriptive you were with what changed about the html, by including the tags and the word "casing". I will keep those descriptions in mind when I open PRs, thank you!

Status: PR Approved!

@myronchen-git
myronchen-git self-requested a review May 29, 2026 11:44
@myronchen-git

myronchen-git commented May 29, 2026 •

Copy link
Copy Markdown
Member

Hi @egcuriel. It looks like you accidentally selected the comment option when reviewing.

@myronchen-git myronchen-git left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for completing this issue. You did a very good job. I didn't see anything that was missed.


Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The what in the pull request description is adequately described.
  • The CodeQL alerts have been correctly checked off.
  • Your before and after screenshots properly shows the changes.
  • Code changes have been correctly made.
  • In the linked issue, you've correctly assigned yourself.
  • In the linked issue, you've correctly set the project status.
  • In the linked issue, action items have correctly been checked off.
  • In the linked issue, you've given your availability and ETA.

@egcuriel

Copy link
Copy Markdown
Member

Hi @egcuriel. It looks like you accidentally selected the comment option when reviewing.

Ah yes I did, thank you for letting me know!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 29, 2026
@xnealcarson
xnealcarson merged commit cd44830 into hackforla:gh-pages May 31, 2026
19 checks passed
@anthonylo87
anthonylo87 deleted the fix-github-casing-7418 branch September 24, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in _guide-pages/2FA.html

4 participants