Remove Amen Divine Ikamba from Hackforla.org Website leadership - #8799
aayush24rai wants to merge 5 commits into
Conversation
…men-divine-ikamba-8769
github-project-automation
Bot
moved this to PR Needs review
in P: HfLA Website: Project Board
github-actions
Bot
added
good first issue
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: End of day Tuesday 9/29 |
MStoutTech
left a comment
MStoutTech
left a comment
There was a problem hiding this comment.
Hi @aayush24rai
Thank you for working on this issue!
There are merge conflicts for you to resolve before I can test your changes.
davidsan13
left a comment
davidsan13
left a comment
There was a problem hiding this comment.
Hi @aayush24rai,
Thank you for working on this issue! I wasn't able to test the branch locally because there is currently a merge conflict. I also noticed that the last sub-checkbox in the issue is not checked right now.
PR Checklist
- Issue is correctly linked.
- Visuals before/after changes are applied.
- The merge from and to branches have been correctly set.
- CodeQL alerts have been checked off.
Needs To Do
- Resolve the current merge conflict so the branch can be tested.
- Check off the last sub-checkbox under the action items in the issue.
Once these are addressed, I can take another look. Thanks!
|
Hi @MStoutTech and @davidsan13 — I've resolved the merge conflict in _projects/website.md and also checked off the last action item. Ready for re-review when you get a chance. Thanks! |
MStoutTech
left a comment
MStoutTech
left a comment
There was a problem hiding this comment.
Hi @aayush24rai
Nice, I can confirm your merge conflict was resolved and I was able to test in my local environment.
You did successfully remove Amen Divine's profile from the appropriate file, however it looks like you may not have synced your code with the main website first
There are other profiles that have been removed in the main website that would be added back if your code was merged.
To do:
- pull from upstream to sync with main website before you push
There was a problem hiding this comment.
Hi @aayush24rai,
Thanks for resolving the merge conflict! I tested the branch locally and confirmed that Amen Divine Ikamba entry is removed successfully. However, I agree with @MStoutTech that the branch is out of sync with gh-pages. As it stands, merging it would re-add leadership entries that were previously removed from _projects/website.md.
Could you please sync your branch?
|
Availability: M-F After 5PM |
This branch has not been deployed
3 participants
Fixes #8769
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied