Repository navigation
Specify default permissions for vrms-data.yml - #8800
Merged
sushma110396 merged 1 commit intoSep 29, 2026
Merged
sushma110396 merged 1 commit into
sushma110396 merged 1 commit into
Conversation
github-project-automation
Bot
moved this to PR Needs review
in P: HfLA Website: Project Board
16 of 34 tasks
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
Bot
added
role: back end/devOps
Member
|
Review ETA: Friday |
ldaws003
self-requested a review
September 25, 2026 15:58
34 tasks done
ldaws003
approved these changes
Sep 25, 2026
ldaws003
left a comment
ldaws003
left a comment
Member
There was a problem hiding this comment.
Hi @anthonylo87, good job on this. You made the required changes of adding the read permissions to vrms-data.yml. Thanks for adding a link and screenshot for the test logs for the job. Approved.
egcuriel
self-requested a review
September 27, 2026 20:42
Member
|
Review ETA: 09/27/2026 EOD |
This comment was marked as duplicate.
This comment was marked as duplicate.
egcuriel
approved these changes
Sep 28, 2026
egcuriel
left a comment
egcuriel
left a comment
Member
There was a problem hiding this comment.
Hi @anthonylo87 !
I tested the GitHub Actions workflow locally using act:
- Verified that the workflow executes with
permissions: contents: readspecified - The payload was downloaded, filtered, and saved to
_data/external/vrms_data.json - The git commit was created with the intended message:
[anthonylo87-specify-YML-default-permissions-8588 97626ccd] Update meeting data
The vrms_data job executes the steps successfully!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8588
What changes did you make?
vrms-data.yml, in order to provide/specify minimum required permissions required by the specified workflow.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Token permissions verified in test logs: