Repository navigation
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
|
Review ETA: 9/28 EOD Availability: |
|
Review ETA: 09/30/2026 EOD |
|
Hi @KyleA99, thank you for working on this! I tested the PR locally and also read your comment about the styling. I was able to see the same things you mentioned. The three location cards are showing in separate rows, the horizontal line is missing, and the subheadings look different from the mockup. I understand that you were not sure if you should add new CSS classes for these changes. I think it would be good to ask the team how they want to handle the styling. I also noticed one small thing. The issue says “Our Locations,” but the mockup says “Our Location,” and the current PR also says “Our Location.” Maybe we should confirm which title we should use. Thank you! |
|
@egcuriel @nathanjkim-codes agreed with the "Location" -> "Locations" change. I fixed that. I'm assuming this was correct, and if it isnt, merge team will address. |
|
Review ETA: 09/30/2026 EOD |
egcuriel
left a comment
There was a problem hiding this comment.
Hi @KyleA99,
As you mentioned your comments there some discrepancies between the mockup and the changes requested on the parent issue. You've followed the instructions on the parent issue, so I approve. If there is any new changes please request a review from me. Thank you!
|
Hi - please let me know when updates have been made and I can review. No rush! Thank you. |
|
Review ETA: 10/3/2026 EOD |
ldaws003
left a comment
There was a problem hiding this comment.
Hi @KyleA99 , great job on the issue. Thanks for explaining the discrepancies from the mockup and the changes you made. That may require another issue to be made, but I'm not sure. Someone higher up would need to clarify. I'll approve.
|
Review ETA: Sat, Oct 3rd Availability: |
computarisis
left a comment
There was a problem hiding this comment.
Hi, @KyleA99! Great job getting this issue going. I was able to validate your branch locally. I did notice the styling discrepancies that have been observed, and I'll wait until it is confirmed whether or not you can add your own css classes (I'd assume so). One little thing, I noticed the sidebar nav menu is no longer sticky for me... Could you double check that?
This comment was marked as resolved.
This comment was marked as resolved.
@castillios On the Tuesday Dev meeting last week @daras-cu mentioned I could add custom css classes to the "about" related scss files so my feature branch aligns with the mock up more. I was going to add that based off our Figma style guide. Should I hold off on that until I hear from you? |
Hi @KyleA99, I apologize for the confusion, please disregard my previous comment. I was unable to attend the previous dev meetings, so I wasn't sure if this was addressed yet. Glad to hear it was worked out and thanks for your continued work on this issue! |
No problem! Appreciate the help. I will be working on that this weekend, and appreciate the reviews and patience from everyone :D |
|
@nathanjkim-codes @egcuriel @anthonylo87 @ldaws003 @computarisis I pushed changes (and re-requested reviews) if you all are able to review again.
@computarisis I saw your comment above regarding the sidebar/nav, but this does appear to be stick for me. Are you talking about this component?
|
|
Hi @KyleA99, thank you for the update Review ETA: 10/07 EOD |
|
Review ETA: 10/07 EOD |
anthonylo87
left a comment
There was a problem hiding this comment.
Hi @KyleA99,
Going to approve this now - but I think a lead needs to look into this and provide a bit more context/open a subsequent issue, as there are still outstanding items to address as you've captured (SVG is missing, location images already have rounded corners/black background.
|
Review ETA: Thu, Oct 8th Availability: |

Fixes #8431
What changes did you make?
I created a new
about-card-our-locations.htmlfile in_includes/about-page/I created a new
our-locations-images.htmlfile in_includes/about-page/I added the new
about-card-our-locations.htmlfile to/pages/about.htmlI added a new li for the new card to the sticky-nav element
Note: Please see the comment I made regarding potential deficiencies in this pull request.
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied