Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented stats page for admins #961

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

implemented stats page for admins #961

wants to merge 2 commits into from

Conversation

pengyk
Copy link
Member

@pengyk pengyk commented Nov 11, 2021 •
edited
Loading

Tickets:

List of changes:

  • Added stats page for admins
  • Could add sponsors to the stats page without access to the table page

Type of change:

  • New Feature

Please delete options that aren't relevant.

  • New feature (non-breaking change which adds functionality)

How did you do this?

How to test:

Questions:

PR Checklist:

  • Merged develop branch (before testing)
  • Linted my code locally
  • Listed change(s) in the Changelog
  • Tested all links in project relevant browsers
  • Tested all links on different screen sizes
  • Referenced all useful info (issues, tasks, etc)

Screenshots

Screen Shot 2021-11-11 at 1 31 42 AM

:

@pengyk pengyk marked this pull request as ready for review November 11, 2021 17:56
logan-r
logan-r requested changes Nov 11, 2021
View reviewed changes
src/api/search.ts Outdated
model,
...searchOptions,
},
});
LocalCache.set(key, result, new Date(Date.now() + 5 * 60 * 1000));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove magic numbers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at the very least comment what they mean :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure!

src/features/Search/Main.tsx
}

private downloadData(): void {
const headers = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in the scope of this PR but we should probably find a more concise mapping function

src/features/Search/Stats/SingleStat.tsx Outdated
<Box width={400}>
<H2 marginLeft={'10px'}>{this.props.statName}:</H2>
<PieChart
width={400}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: inconsistent indentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@pengyk pengyk requested a review from logan-r November 18, 2021 17:52
@chenxuan-zhou chenxuan-zhou mentioned this pull request Nov 29, 2021
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreTklein pierreTklein pierreTklein left review comments

@logan-r logan-r Awaiting requested review from logan-r

Requested changes must be addressed to merge this pull request.

Assignees

@pengyk pengyk

@meldunn meldunn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pengyk @logan-r @pierreTklein @meldunn