Use experimental Miso components support #1324
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgefst
force-pushed
the
georgefst/miso-components
branch
from
42ec653 to
de4d88e
Compare
|
We're in no hurry, so we might as well wait a bit for the components Wasm support. |
This is generally a good idea for performance reasons, since it means that `JSString` is used when compiling for JS or Wasm. And Miso's upcoming components support is stricter about requiring it. Signed-off-by: George Thomas <[email protected]>
This does not, or at least should not, yet cause any changes in functionality. Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
georgefst
force-pushed
the
georgefst/miso-components
branch
from
de4d88e to
5424a8e
Compare
|
Well, we didn't have to wait very long! Miso's components now work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dmjio/miso#766.
This works, until the last commit, where we try to actually add a component, which causes the app to crash with
TypeError: obj.mount is not a function. The Miso components branch does not yet support Wasm (orjsaddle-warp) due to a need for synchronous callbacks, but this is being worked on at this very moment.If upstream support does appear in the next week or so, then I propose that we use this as the basis for the next stage of frontend development, i.e. we rebase my WIP actions and eval work on top of this. Both the actions and eval panels would benefit from being components since they have a natural notion of internal state. I would otherwise have considered fake components as outlined here, but I'd say we're better off embracing the future. The success of the frontend rewrite so far has been built on using bleeding edge features and working closely with upstream maintainers. I see no reason to stop now!