Skip to content

Conversation

amjjbonvin
Copy link
Member

@amjjbonvin amjjbonvin commented Aug 31, 2025

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines.

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Modifications / enhancements are reflected on the haddock3 user-manual
  • CHANGELOG.md is updated to incorporate new changes
  • Haddock3 version has been incremented in pyproject.toml
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

Added a new directory (notebooks) with a first Jupyter notebook for the antibody-antigen tutorial running on Colab

Related Issue

Closes #1367

@amjjbonvin amjjbonvin self-assigned this Aug 31, 2025
@amjjbonvin amjjbonvin added the enhancement Improving something in the codebase label Aug 31, 2025
@github-project-automation github-project-automation bot moved this to In progress in Enhancements Aug 31, 2025
- defining the default run directory and cleaning the commands
- adding option to copy the data to your Google Drive
@rvhonorato rvhonorato added feature Adding something new to the codebase and removed enhancement Improving something in the codebase labels Sep 1, 2025
@rvhonorato rvhonorato removed this from Enhancements Sep 1, 2025
@rvhonorato
Copy link
Member

I also see this PR is not tied to any issue - please add an issue before merging

@amjjbonvin
Copy link
Member Author

I also see this PR is not tied to any issue - please add an issue before merging

related to issue #1367

@rvhonorato
Copy link
Member

so please link it here

@amjjbonvin
Copy link
Member Author

amjjbonvin commented Sep 1, 2025 via email

@amjjbonvin
Copy link
Member Author

amjjbonvin commented Sep 1, 2025 via email

Added instructions for running locally
@amjjbonvin
Copy link
Member Author

Updated the README file, linked to the issue.
But we still have the issue that the interactive plots are not showing when running locally (while it works on colab).

@amjjbonvin amjjbonvin marked this pull request as draft September 3, 2025 06:41
@amjjbonvin
Copy link
Member Author

@rvhonorato - as the installation now has the notebooks option, the notebooks tests should only be performed if it was installed with this option. Currently the tests are failing. Can you check/fix it?

@amjjbonvin
Copy link
Member Author

PS: The notebook will have to be updated to use the main version once the notebooks branch will have been merged.

@amjjbonvin amjjbonvin marked this pull request as ready for review September 3, 2025 07:50
@rvhonorato rvhonorato marked this pull request as draft September 3, 2025 08:57
@rvhonorato
Copy link
Member

Marking this as a draft because it's not ready yet. The addition of the libnotebooks (and its tests) needs to done in a separate PR, it should then be merged and published to pypi and used here.

The latest changes have tied the execution of this notebook to a git clone which is very error prone and likely to make the notebook unstable.

Once the other PR is merged we can resume work on this one

@rvhonorato rvhonorato mentioned this pull request Sep 3, 2025
7 tasks
@rvhonorato
Copy link
Member

before merging this it would also be good to check how we can use Binder for it and add it in the repository README - https://mybinder.org

@amjjbonvin amjjbonvin closed this Sep 4, 2025
@amjjbonvin amjjbonvin deleted the notebooks branch September 4, 2025 13:52
@rvhonorato rvhonorato mentioned this pull request Sep 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding something new to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Jupyter notebooks as tutorials
2 participants