Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split into smaller components #16

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

split into smaller components #16

wants to merge 9 commits into from

Conversation

hadeeb
Copy link
Owner

@hadeeb hadeeb commented Apr 10, 2020

Splits the component into smaller component for each hydration strategy.
closes #14

Notes on hydration when visible

To support IntersectionObserver customizations, an IntersectionObserver instance is created for each component unique set of IntersectionObserver options.
As an alternative to this, the component can accept a custom IntersectionObserver instance like this. It could be beneficial if there is a list of components to be hydrated in a same way or the user needs more control on hydration.

@hadeeb hadeeb changed the title split into smaller components Splits the component into smaller component for each hydration strategy Apr 10, 2020
@hadeeb hadeeb changed the title Splits the component into smaller component for each hydration strategy split into smaller components Apr 10, 2020
@hadeeb hadeeb force-pushed the split-components branch from 40ea0c1 to 7f5b54b Compare April 10, 2020 19:56
@hadeeb
Copy link
Owner Author

hadeeb commented Apr 13, 2020

Name of exported components could be improved.
The readme also has to be updated to reflect these changes.

@nilanjansiromani
Copy link

@hadeeb Can you check if phantomJS will support this
Some legacy codes use Phantomjs still as the unit test driver

@nilanjansiromani
Copy link

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export multiple components
2 participants