Add listenOnEl prop #25
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add package-lock.json
Add .prettierrc.json file
Stricter tyepscript
|
@ScriptedAlchemy i think you meant to review this PR instead #24 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant lines to review:
Adds a
listenOnElprop to allow the consumer to specify which element to listen on for events. In my use case, I want to hydrate as soon as an event happens anywhere on the document, rather than on the child element.Pairs nicely with the new
noWrapperprop.This is currently in draft mode because it depends on some of the other PRs I submitted (these lines will conflict with the changes in #24) , I can rebase it if it's reviewed/accepted. Until then, I'll be using it on my fork