Skip to content

attach Interaction Observer to first visible child (handle 'display: contents') #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

attach Interaction Observer to first visible child (handle 'display: contents') #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,21 @@ function reducer() {
return true;
}

// find a visible node to observe
// NOTE: this just checks the first child at each level
function getFirstVisibleChild(el) {
const child = el.firstElementChild;
if (child) {
const style = getComputedStyle(child);
// element might contain visible children
if (!["contents"].includes(style.display)) {
return child;
}

return getFirstVisibleChild(child);
}
return child;
}
function LazyHydrate(props: Props) {
const childRef = React.useRef<HTMLElement>(null);

Expand Down Expand Up @@ -92,7 +107,7 @@ function LazyHydrate(props: Props) {
const element = noWrapper
? rootElement
: // As root node does not have any box model, it cannot intersect.
rootElement.firstElementChild;
getFirstVisibleChild(rootElement);

if (element && typeof IntersectionObserver !== "undefined") {
const observerOptions =
Expand Down