Conversation
- Fix DEFAULT_SUPPORTED_EXTS to only include actually supported languages (java, ts, py) - Fix cache clear to reset supported extensions to defaults instead of empty array - Filter out directory entries in getFilesInPR to prevent folder paths from being checked - Filter out directory entries in buildFilePathToDiffIdMapAsync to prevent corrupted mappings - Remove ellipsis from "Enriching..." button text - Add test/capture-console.js for automated console output capture Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…oken fix - Add animated dots to loading status indicators - Simplify user-facing error messages (no technical details) - Handle SKIPPED aiReviewStatus (no polling, no loading) - Modern toast styling with backdrop blur and slide-in animation - Right-align thumbs up/down feedback buttons under note boxes - Add "Thanks for the feedback!" message after voting - Fix Turbo SPA navigation showing stale diagrams from cached pages (turbo:before-cache strips extension-injected content) - Make engagementWriteToken/operationId non-blocking in validation (diagram renders regardless, telemetry is silently skipped) - Add 30s token suggestion toast when generation is slow without token - Restructure smoke test: navigate first, then set config (fixes CDP SW detection) - Change default API base to localhost:8080 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…load, harden toast XSS - Add copy-to-clipboard button on AI review notes (left: thumbs up/down, right: clipboard) - Fix file explorer disabling non-source files on cache load when user is in diff view (updateFileTreeAvailability now checks current view before disabling) - Harden toast rendering: default to textContent, only use innerHTML when html:true is explicitly passed (prevents XSS from server-controlled error messages) - Remove localhost from manifest host_permissions, default API base to api.striff.io - Update icons, fix zoom binding, stale diagram cleanup - Add Chrome Web Store link to README Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 553d4e320e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+4
to
+5
| "name": "_gh_sess", | ||
| "value": "9YYjMua6nL0Ix3fqy16LOqR7rZ6yAXtvGb1tSAQVmivTMmpZmO2vmqzKfV%2FoKBfnZOZ1zYEZgP%2FlvvrBiRkyDwCY1ZB%2FNBIokN%2BzFSqhSJwSrYIQhBufcG08DwI68cXJSEU5Ut11FsNxXVslgT2skXoON%2Fr0d5PlN7P1yg3dIAdt%2F6VzwF9A4MmFxNMkw5bXdQGujw5jzgmmRC6FI%2BkYmi0Zl3v3MP5HrRdjOmRUjiUQ6ecR%2FjWmmGKbg1mS5oocNlApyrxtXiu06qEi7r4I%2FA%3D%3D--GgDr61HSdcK%2BhU07--ZNnpXf0K%2FdM%2BFV4UxH6fXw%3D%3D", |
There was a problem hiding this comment.
This file commits a live _gh_sess cookie value into version control, which is sensitive session material and can enable account/session hijacking if reused before expiry. Test fixtures should not include real authentication cookies; scrub this file or replace it with sanitized dummy data before merging.
Useful? React with 👍 / 👎.
Comment on lines
+8
to
+9
| test/.pw-*/ | ||
| test/.pw-profile-*/ |
There was a problem hiding this comment.
The ignore patterns only match test/.pw-* at one directory depth, but this commit adds profile data under test/test/.pw-profile-debug* (including Cookies/Login Data databases). Because those paths are not ignored, future local test runs will keep committing machine-specific browser state and potentially more credentials. Update the pattern to match nested profile paths as well.
Useful? React with 👍 / 👎.
Broaden isReviewNoteQualifiedName and extractReviewNoteId to recognize the surfaced_note_ prefix used by ADR-015 surfaced review items, in addition to the legacy AI_REVIEW_NOTE_ prefix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Broaden isReviewNoteQualifiedName and extractReviewNoteId to handle both AI_REVIEW_NOTE_ and surfaced_note_ prefix formats from ADR-015. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…w composer When a review box is already open on the Preview tab, the textarea exists but is not visible. The previous code would give up and try clicking the review button again, which doesn't work. Now we detect this case and intelligently switch to the Write tab first, checking visibility again after switching. This handles the "Could not open GitHub's review text box" error when starting a review with a diagram and the review composer is already open on the Preview tab. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
striff-api removed the riskLevel field (demoted to backward-compat-only per its ADR-013 Part D, now fully retired) since it was computed independently of SurfacedReviewPriority and could disagree with it. The top "Risk Level" badge and the "Everything looks good" empty-state check in buildArchReviewPanelHtml now derive from the highest priority present in surfacedItems (Structural Regression > Review Hotspot), reusing the existing SURFACED_PRIORITY_SEVERITY/LABEL maps already used for per-item badges. Also removed the now-unused riskLevel field from the manual smoke-test fixture generator. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.