chore: introduce ameba lint baseline - #9
Merged
Merged
Conversation
- Add ameba as a development dependency with a project .ameba.yml - Disable Naming/QueryBoolMethods since public API uses `result.success` and `obj.active` (no trailing ?) - Change FFI callback return types from Void to Nil in src/fm/session.cr (Void outside of `lib` is flagged by ameba and Crystal convention) - Flesh out shard.yml metadata (repository, homepage, documentation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ameba.ymlAmeba now passes with 0 findings and the spec suite (170 examples) stays green.
Test plan
crystal run lib/ameba/bin/ameba.cr→ 26 inspected, 0 failurescrystal spec→ 170 examples, 0 failures