Fix/1547 bookmarks sublayers not displayed #1552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the ability to store and restore the visibility of sublayers (group layers) within bookmarks. Previously, only the main layers were tracked when a user created a bookmark, which meant any sublayer selections would be lost upon restoring the map state. This enhancement ensures that sublayers, particularly those in group layers, are saved as part of the bookmark and can be restored properly when the user revisits the bookmark.
This commit ensures that previously stored bookmarks, which do not have the 'gl' (group layers) parameter, can still be loaded without causing errors.
This commit fixes an issue in the Bookmarks plugin where sublayers from group layers were not correctly shown as toggled in the LayerSwitcher after loading a bookmark. While the sublayers were visible on the map, their checkboxes remained unchecked. The solution synchronizes the visibility state of sublayers with the LayerSwitcher, ensuring the checkboxes accurately reflect the map's state when a bookmark is loaded.
Resolved an issue where sublayers were toggled on app start when they shouldn't have been.
This commit fixes an issue where the v2 API was using POST instead of PUT for saving documents. The `DocumentHandler` in `admin` was sending POST requests for all versions, which worked with v1 but failed with v2 endpoints. The solution updates the API to handle both versions correctly while maintaining backwards compatibility, ensuring documents can be saved regardless of which API version is used.
This commit resolves an error that occurred when saving documents with the NodeJS backend. The backend was trying to parse data that was already in the correct format, causing saves to fail with a 500 error.
This reverts commit acf6992.
This reverts commit b3457d3.
Fixed an issue where creating a bookmark for an entire group layer did not toggle sublayers correctly when the bookmark was loaded.
…-sublayers-not-displayed
|
I see that there are some changes in the LayerSwitcher included. Have you discussed this with with Jakob who is working on the new LayerSwitcher? |
|
Closing due to #1568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1547.