Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contract support to actions #453

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Add contract support to actions #453

merged 6 commits into from
Sep 2, 2024

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    e30f71a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42a76dd View commit details
    Browse the repository at this point in the history
  3. Formalize contract support in Params, drop dependency on Hanami::Vali…

    …dations code
    
    Add `Hanami::Action::Params.contract` as a counterpart to `Hanami::Action::Params.params`, allowing `Hanami::Action.contract` to use this API as opposed to directly setting a class-level ivar. This cleans up the remaining “hacky” aspect of my initial `Hanami::Action.contract` introduction.
    
    Secondly, stop using code from `Hanami::Validations` altogether. I always found this code too indirect and hard to follow. Instead, introduce the one bit of important logic (the base validator class permitting the `_csrf_token`) directly into `Hanami::Action::Params`, which means this class is now entirely standalone. This will make it easier to adjust/maintain in future.
    timriley committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    37dbc3e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Tidy, update docs

    timriley committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e63ba72 View commit details
    Browse the repository at this point in the history
  2. Expand tests

    timriley committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    408524d View commit details
    Browse the repository at this point in the history
  3. Tidy params tests

    timriley committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    63338ab View commit details
    Browse the repository at this point in the history