Repository navigation
Add RuboCop to CI and fix violations - #352
Merged
Merged
Conversation
brkn
force-pushed
the
ci/add-rubocop
branch
4 times, most recently
from
October 29, 2025 01:37
dadc722 to
c310b32
Compare
timriley
force-pushed
the
ci/add-rubocop
branch
from
October 31, 2025 02:58
869ffb5 to
0bdd02c
Compare
Member
|
Thanks @brkn! I think all the decisions you made here are good. We can realign this with our synced files once we work through the hanami repos in general. Until then, getting Rubocop happy is a great outcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #339
Differences from other repos
ci script
run_unit_tests() { - bundle exec rake spec:unit + bundle exec rake spec }Not using repo sync
Not using hanaki's cop config