Skip to content

Add RuboCop to CI and fix violations - #352

Merged
timriley merged 4 commits into
hanami:mainfrom
brkn:ci/add-rubocop
Oct 31, 2025
Merged

timriley merged 4 commits into
hanami:mainfrom
brkn:ci/add-rubocop

Conversation

@brkn

@brkn brkn commented Oct 24, 2025 •

Copy link
Copy Markdown
Contributor

Related to #339

Differences from other repos

ci script

run_unit_tests() {
-  bundle exec rake spec:unit
+  bundle exec rake spec
}

Not using repo sync

- ci.yml
- rubocop.yml

Not using hanaki's cop config

@brkn
brkn force-pushed the ci/add-rubocop branch 4 times, most recently from dadc722 to c310b32 Compare October 29, 2025 01:37
@timriley

Copy link
Copy Markdown
Member

Thanks @brkn! I think all the decisions you made here are good. We can realign this with our synced files once we work through the hanami repos in general. Until then, getting Rubocop happy is a great outcome.

@timriley
timriley merged commit 5a5ae96 into hanami:main Oct 31, 2025
6 checks passed
@brkn
brkn deleted the ci/add-rubocop branch October 31, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants