[svoop]

This adds --gem-server to hanami new which facilitates the use of an alternative or private gem server:

hanami new --gem-server=https://gem.coop bookshelf

Closes #356

[timriley]

@svoop Thanks for doing this! Looks like you've included one of my earlier commits by accident?

[timriley]

Also, bit of feedback: we should make this so that --gem-server=gem.coop is a valid argument. The feels a lot better than having to type the full https:// in front. So: if there's a URI scheme given, accept it, otherwise prefix the given argument with https://. Does that sound OK?

[svoop]

@timriley

Thanks for doing this! Looks like you've included one of my earlier commits by accident?

Ah, classic, one small click for a man, a giant mess for the PR. No problem though, I'll fix this.

we should make this so that --gem-server=gem.coop is a valid argument

You're right, particularly since the CLI arg is called --gem-server, the protocol is not really needed there. I included it to accommodate probably purely theoretical situations in which someone runs a private gem server or mirror locally without SSL. But in this case, the CLI arg had better be named --gem-source. I usually prefer alignment (e.g. --gem-source maps to source in the Gemfile) for transparency, but I'm indifferent on this one, even more so since it will eventually be replaced by interactive prompts, so I'll change that as well.

All that right after some inevitable morning exercise and a good cup of coffee. 😄 Thanks for the feedback!

[timriley]

@svoop oh yes, let's go with --gem-source. This was the name I had envisioned earlier, but I typed the wrong then when I created this ticket.

[timriley]

(Updated the ticket title to reflect this)

[svoop]

Alright, just to confirm, that's --gem-source but without the protocol, isn't it?

[timriley]

@svoop I think we should allow both (in the spirit of Postel's law):

--gem-source=gem.coop
--gem-source=https://gem.coop

We should document the first. It's nicer looking and easier to type :)

[svoop]

@timriley Here you go: CLI arg is now --gem-source with or without scheme. Btw: My initial test was flawed, I've fixed that as well. However, I'm not using kwargs (but merge into it) in the newly added tests in new_spec.rb because by doing so I wouldn't be able to test the default gem source "rubygems.org".

[timriley]

Thanks @svoop, this is great! The testing approach seems sensible to me too.