Use threads instead of forking to compile slices assets#404
Open
Use threads instead of forking to compile slices assets#404
Conversation
I haven't found any compelling reason to prefer `fork` here over threads and this enables assets compilation on JRuby.
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the main blockers for JRuby adoption in Hanami is that Hanami CLI uses
forkto spawn assets compilation for slices in parallel. I was trying to find a reason why it was done like that for a while, but could not find any. I also recently found hanami/hanami#1524 (comment) which asks about the same and no conclusion was made.This PR replaces
Process.forkwithThread.new. In my tests everything still works and assets are being compiled in parallel.