Conversation
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
katafrakt
approved these changes
May 4, 2026
timriley
approved these changes
May 4, 2026
Member
There was a problem hiding this comment.
Thanks @kyleplump!
Couple of little adjustments:
- Can we move this down into the
:test, :developmentgroup? We don't need syntax highlighting (nor the related dependency) in production. - This could do with a comment above it, since I think users will not be able to infer why it's there. Something simple like "Syntax highlighting SQL logs" would be enough.
Once you're done with those, happy for you to merge :)
added 2 commits
May 6, 2026 09:06
Member
Author
|
I debated where it should go, thank you for the direction @timriley! Both of your requested changes have been implemented |
Member
|
Perfect, thank you @kyleplump! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the
rougegem in the defaultGemfilefor new apps. It will not include the gem ifskip-dbflag is passedCloses #394