Add array variables extraction + injection around Mustermann expand method#304
Open
inouire wants to merge 1 commit into
Open
Add array variables extraction + injection around Mustermann expand method#304inouire wants to merge 1 commit into
inouire wants to merge 1 commit into
Conversation
Contributor
Author
|
Or maybe would it be Mustermann responsibility to do it in the expand function? |
Contributor
Author
|
@timriley do you think it can be part of next release? Thanks |
Member
|
@inouire thank you for the nudge! Yes, this will absolutely be going in. I'll make sure I review it soon. We'll have a 3.0 rc coming out in a few weeks, and this will be included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #303
It's a bit tricky to handle array query variables as Mustermann handled expansion by itself.
We have to extract array variables of its scope otherwise it will choke on non-array variables
We can add serialized arrays afterwards so that Mustermann is not aware of them