Skip to content

Add array variables extraction + injection around Mustermann expand method#304

Open
inouire wants to merge 1 commit into
hanami:mainfrom
inouire:router-path-array-params
Open

Add array variables extraction + injection around Mustermann expand method#304
inouire wants to merge 1 commit into
hanami:mainfrom
inouire:router-path-array-params

Conversation

@inouire
Copy link
Copy Markdown
Contributor

@inouire inouire commented Apr 27, 2026

Trying to fix #303

It's a bit tricky to handle array query variables as Mustermann handled expansion by itself.

We have to extract array variables of its scope otherwise it will choke on non-array variables

We can add serialized arrays afterwards so that Mustermann is not aware of them

@inouire
Copy link
Copy Markdown
Contributor Author

inouire commented Apr 28, 2026

Or maybe would it be Mustermann responsibility to do it in the expand function?

@inouire
Copy link
Copy Markdown
Contributor Author

inouire commented May 11, 2026

@timriley do you think it can be part of next release? Thanks

@timriley
Copy link
Copy Markdown
Member

@inouire thank you for the nudge! Yes, this will absolutely be going in. I'll make sure I review it soon. We'll have a 3.0 rc coming out in a few weeks, and this will be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while trying to generate an URL with an array query parameter

2 participants