fix(named-expressions): mark named expressions as dirty before re-computation #1504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It fixes an issue where named expressions were not marked as dirty after clearing dirty nodes in
setCellContents
, causing dependent formulas not to update correctly on subsequent value changes.The fix ensures that all active named expressions are safely re-marked as dirty before recomputation in the
recomputeIfDependencyGraphNeedsIt
function.How did you test your changes?
Manually tested by:
Ran the existing unit tests to ensure no regressions were introduced.
Types of changes
Related issues:
Checklist: