Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install module rules #323

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Install module rules #323

merged 3 commits into from
Sep 16, 2024

Conversation

mathstuf
Copy link
Contributor

No description provided.

@mathstuf
cmake/modules: use FILE_SET to provide include directories
7f9ffc4 
The `BASE_DIRS` missing caused the `target_include_directories` command
to be required. Instead, specify the base directory to move the
subdirectory to the `-I` flag instead.
@mathstuf
cmake/install: install packages to libdir instead of datadir
3af31bb 
The modular build has a static library that is architecture-dependent.
This library contains the module initialization symbol for the `ctre`
module.
@mathstuf
cmake/install: enable installation for the modules build
8c94f42
@mathstuf
Copy link
Contributor Author

Here is the build log from a project doing find_package(ctre) and using the module-enabled build:

[6-3->1/[email protected]] Scanning CTRE_PREFIX/lib64/cxx/ctre/ctre.cppm for CXX dependencies
[6-2->2/[email protected]] Scanning LLVM_PREFIX/share/libc++/v1/std.compat.cppm for CXX dependencies
[6-1->3/[email protected]] Scanning LLVM_PREFIX/share/libc++/v1/std.cppm for CXX dependencies
[5-1->4/[email protected]] Generating CXX dyndep file CMakeFiles/__cmake_cxx23.dir/CXX.dd
[4-1->5/[email protected]] Generating CXX dyndep file 'CMakeFiles/ctre__ctre@synth_d2beb5079b65.dir/CXX.dd'
[3-1->6/[email protected]] Scanning FOO_SOURCE/foo.cpp for CXX dependencies
[2-1->7/[email protected]] Generating CXX dyndep file CMakeFiles/foo.dir/CXX.dd
[3-1->8/[email protected]] Building CXX object CMakeFiles/__cmake_cxx23.dir/LLVM_PREFIX/share/libc++/v1/std.cppm.o
[2-1->9/[email protected]] Building CXX object 'CMakeFiles/ctre__ctre@synth_d2beb5079b65.dir/d3d7d81f8100.bmi'
[1-1->10/[email protected]] Building CXX object CMakeFiles/foo.dir/foo.cpp.o
[0-1->11/[email protected]] Linking CXX executable foo

@hanickadot hanickadot merged commit 68629cc into hanickadot:main Sep 16, 2024
60 of 62 checks passed
@mathstuf mathstuf deleted the install-module-rules branch September 16, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathstuf @hanickadot