-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Sun Gecko Helper #3097
Conversation
One or more Detekt Failures were detected:
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
One or more Detekt Failures were detected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a review, apart from this there are some methods and vals that should be made private
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
One or more Detekt Failures were detected:
|
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/area/mountaintop/SunGeckoHelper.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/rift/area/mountaintop/SunGeckoConfig.java
Outdated
Show resolved
Hide resolved
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
One or more Detekt Failures were detected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo test is missing
@hannibal002 i added the test for that regex so that everyone knows all the ways that string could be shown |
What
Adds a sun gecko helper that shows your current combo and how long until you lose it
Images
I may have played a lot of gecko

Changelog New Features