Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "used energy" #46

Closed
wants to merge 1 commit into from
Closed

Conversation

tkilla77
Copy link

See issue #45.

This is just a preliminary request to start the discussion before I start investing... - would you be open for a real request?

What kind of code quality & test coverage do you require?

Missing: Translations other than German
Missing: Tests

…s in Luxtronik V3.88.0

This could be useful to compute COP / SEER (de. JAZ).

Missing: Translations other than German
Missing: Tests
@tkilla77 tkilla77 marked this pull request as draft May 23, 2023 15:25
@hansmi
Copy link
Owner

hansmi commented May 23, 2023

What kind of code quality & test coverage do you require?

Looks good as a draft. Can you please cover the new code in collector_test.go:TestCollectWebSocketParts?

To get the non-German strings I'd recommend switching the controller to the respective language. There's also wp2reg-language-extractor, but it only works if the software version uses the external files. At some point they switched to embedding the strings in the binary, making them harder to extract (see also #37). I didn't update the tool accordingly.

@hansmi
Copy link
Owner

hansmi commented Jun 21, 2023

@tkilla77, do you plan to keep working on this feature?

@tkilla77
Copy link
Author

@tkilla77, do you plan to keep working on this feature?

Sorry for the long delay... unlikely I will find time in the next three weeks to work on this. Feel free to close.

@hansmi
Copy link
Owner

hansmi commented Oct 6, 2023

Please re-open this PR when you had time to work on it again.

@hansmi hansmi closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants