Fix rendering of images with JPEG slices #1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include hex opcode and file offset in debug output. Condense scan line messages in readOpDirectBits().
Some files contain multiple image "slices", each compressed with QuickTime JPEG compression. These need to take the matrix into account to combine them properly. Additionally, these images have a placeholder icon, rendered with PackBitsRect, to indicate that QuickTime is needed which should be suppressed if the CompressedQuickTime operation succeeded. See for example J19.pict.
haraldk
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Again, thanks!
I think this PR has some issues though, first of all, it contains the changes from the previous PR, making this PR hard to merge without first merging the other.
It also contains the same formatting issues as the other (4 space/8 spaces continuation/no tabs). Let me know if you would like me to share my code style settings.
The sample image is great, but we also need to add it to the PICTImageReaderTest and create a test that fails without these changes, to prove that the change actually fixes what it is intended to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files contain multiple image "slices", each compressed with QuickTime JPEG compression. These need to take the matrix into account to combine them properly. Additionally, these images have a placeholder icon, rendered with PackBitsRect, to indicate that QuickTime is needed which should be suppressed if the CompressedQuickTime operation succeeded. See for example J19.pict.