Fix dns-blacklisting reward bug, standardize task.toml format#22
Merged
benediktstroebl merged 2 commits intomainfrom Mar 24, 2026
Merged
Fix dns-blacklisting reward bug, standardize task.toml format#22benediktstroebl merged 2 commits intomainfrom
benediktstroebl merged 2 commits intomainfrom
Conversation
- dns-blacklisting test.sh: the || true + PIPESTATUS[0] pattern always reported reward=1 regardless of test outcome. Replaced with standard $? pattern used by all other recipes. - simple-task and multi-reward task.toml: standardize memory/storage fields to memory_mb/storage_mb matching the other 6 recipes. - multi-reward README: move the required -c config.yaml flag into the primary run command since harbor run crashes without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested all 8 recipes with oracle agent (8/8 pass) and 5 with live codex/gpt-5-mini (5/5 pass). Found and fixed:
|| true+PIPESTATUS[0]pattern was broken — confirmed by running a failed agent that still got reward=1. Replaced with the standard$?pattern used by all other recipes.memory = "2G"/storage = "10G"while the other 6 recipes usedmemory_mb/storage_mb. Standardized to the majority format.-c config.yamlflag in a "Metrics note" section. Without it,harbor runcrashes withValueError: Expected exactly one key in reward dictionary, got 2. Moved it front and center.