Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created post_details.html #16

Closed
wants to merge 3 commits into from
Closed

Created post_details.html #16

wants to merge 3 commits into from

Conversation

Joshitha18
Copy link

@Joshitha18 Joshitha18 commented Aug 13, 2020

Fixes #13
When clicked on title of a post on home page, it'll be redirected to a new page containing post details
working

@Joshitha18 Joshitha18 changed the title Creted post_details.html Created post_details.html Aug 13, 2020
@harsh7in harsh7in self-requested a review August 16, 2020 15:36
@harsh7in
Copy link
Owner

@SKAUL05 plz review this

@SKAUL05
Copy link

SKAUL05 commented Aug 16, 2020

@SKAUL05 plz review this

Sure assign me as reviewer.

@SKAUL05 SKAUL05 self-requested a review August 17, 2020 06:35
Copy link
Collaborator

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM :)
@Joshitha18 can you please add a GIF in the PR description showing the functionality you added so that we can be sure that it's working fine.

@Joshitha18
Copy link
Author

@Kajol-Kumari Added requested changes

Copy link
Collaborator

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged now @harsh-9in

@harsh7in harsh7in added CH20 Hakincodes easy labels Aug 18, 2020
@Kajol-Kumari
Copy link
Collaborator

Hey @Joshitha18 please resolve the conflict here otherwise we won't be able to merge it.

@Joshitha18 Joshitha18 closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH20 Hakincodes easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A seperate page for each post
4 participants