Fix SQL injection vulnerability in Redshift fetch_table#5
Open
shaikjr wants to merge 2 commits into
Open
Conversation
Owner
|
Nice security improvement overall switching from f-string SQL to psycopg2.sql.Identifier + parameterized LIMIT is the right fix. |
Author
|
Good catch the validation was overly restrictive for schema-qualified names. Since psycopg2.sql.Identifier already safely handles identifier escaping, I’ll remove the custom validation to avoid blocking valid table references like public.users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fetch_table function used an f-string to build the SQL query, allowing the table name to be injected directly into the query. This fixes it by using psycopg2.sql.Identifier for safe identifier composition and parameterized queries for the LIMIT value. Also added a basic validation check on the table name.
Also removed two stray Windows Zone.Identifier files that were accidentally tracked.